Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Footer To Use Absolute Paths For Images #1925

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

yashTEF
Copy link
Contributor

@yashTEF yashTEF commented May 21, 2024

Changes relative paths in footer for images to absolute, for fragment/template usage.

Copy link

netlify bot commented May 21, 2024

Deploy Preview for jakartaee ready!

Name Link
🔨 Latest commit d5124c5
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee/deploys/665601a423e7df000811f465
😎 Deploy Preview https://deploy-preview-1925--jakartaee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yashTEF
Copy link
Contributor Author

yashTEF commented May 21, 2024

@autumnfound , Could you review this?

So eclipse-ee4j/starter#293 can be closed.

@autumnfound
Copy link
Contributor

@oliviergoulet5 if we want to use absolute URLs, the Hugo equivalent is {{ absURL "/images/jakarta/jakarta-ee-logo-white.svg" }}, correct? It's been a little while so I'm rusty and I want to confirm.

@yashTEF once I confirm the syntax, we should switch to this. We use preview links that allow us to have previews of functionality, so hard-coding the production host could lead to errors in previews if the assets ever change.

@oliviergoulet5
Copy link
Member

@autumnfound That's correct

@yashTEF
Copy link
Contributor Author

yashTEF commented May 28, 2024

@yashTEF once I confirm the syntax, we should switch to this. We use preview links that allow us to have previews of functionality, so hard-coding the production host could lead to errors in previews if the assets ever change.

Yes, I was confused too when I saw how urls were being referenced in the header/navbar.

Will change to this.

@autumnfound autumnfound merged commit 53c6e72 into jakartaee:src May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants